New Feature: Add depth support to TaggerGetTags #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theboxer
approved these changes
Jan 4, 2021
theboxer
requested changes
Jan 4, 2021
| $c->where(array( | ||
| 'Resource.parent:IN' => $parents, | ||
| )); | ||
| if (!empty($parents)) { |
There was a problem hiding this comment.
Seems like duplicit condition:
if (!empty($parents)) {
if (!empty($parents)) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds a new optional
depthparameter to TaggerGetTags that adds a search depth for child resources for each parent.To keep this bc I guess the default should be changed to
1- I've set it as10.Use like:
Why is it needed?
Currently when using the
parentsparameter only tags from immediate child resources are returned. This allows fetching tags from deeper down the resource tree.